add test for current pure logic#74
Merged
alexander-akait merged 2 commits intocss-modules:masterfrom Oct 31, 2024
Merged
Conversation
This was referenced Aug 6, 2024
alexander-akait
approved these changes
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a small next.js demo project with the following css code:
Stackblitz without postcss-nesting
without postcss-nesting
.page { button { .. } }is not pure:however the same css code works once you add
postcss-nestingStackblitz with postcss-nesting

I took a look and found out the reason:
without postcss-nesting the selector is
button(which is not pure)with postcss-nesting the selector is
.page button(which IS pure according to postcss-modules-local-by-default)To proof that I added a new passing test case without modifying the logic: